Conversation
Owner
Author
|
@codex review this please |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Owner
Author
|
@claude review |
GetTargetPlatform() returned "x64" on any 64-bit process, which on Apple Silicon (and other ARM64 hosts) caused the forked vstest to abort with "Could not find 'dotnet' host for the 'X64' architecture". The fork never connected back to the parent's TCP listener, so the parent blocked forever in WaitForProcessId until the assembly Timeout fired. Detect the architecture via RuntimeInformation.ProcessArchitecture so the fork runs in the same architecture as the parent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
FSDirectory.FSIndexOutput.Dispose: - Collapse the nested try blocks to two levels (per review). - Document why upstream Java has no flush race (RandomAccessFile.write is unbuffered, unlike FileStream's managed buffer). - Make Dispose run-once via an atomic Interlocked guard so two racing threads can't both run the dispose logic (per review). TestIndexWriterOnJRECrash fork harness: - Only pass RunConfiguration.TargetPlatform when running as x86; let vstest auto-detect a compatible host on x64/ARM64. - Add EnsureForkPlatformSupported(): mark the test Inconclusive when the 32-bit .NET SDK is not installed on x86 (required separately since .NET 8) instead of hanging. - WaitForProcessId no longer blocks forever: poll for connect-back or fork exit, and hard-fail with the fork's exit code and captured STDERR on startup failure or timeout. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FSIndexOutput’s managedFileStreambuffer before marking the file stale forSync().TestIndexWriterOnJRECrash.TestNRTThreads_Memand makeCheckIndexes()dispose the wrapper safely without leaking the directory.Testing
Lucene.Net.Store.TestDirectoryinsrc/Lucene.Net.Tests._J-Ssuccessfully.TestIndexWriterOnJRECrash.TestNRTThreads_Meminsrc/Lucene.Net.Tests._I-Jsuccessfully, including the forked crash path.